Add BASE_IMAGE usage comments to Dockerfiles#261
Merged
Conversation
Explain that ARG BASE_IMAGE defaults exist for standalone docker build and that build.sh overrides them via --build-arg.
…fy failed on deep-review infra (temp repo missing CMakeLists.txt), not code. Dockerfile comment changes are in working tree. Commit, push pr-k-docker-pkgs, and open PR against main. Skip deep-review — Dockerfile-only change, no Docker CI; infra bug tracked as P14.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
=======================================
Coverage 85.00% 85.00%
=======================================
Files 127 127
Lines 6181 6181
=======================================
Hits 5254 5254
Misses 927 927 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
chhwang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add BASE_IMAGE usage comments to Dockerfiles
Document the
ARG BASE_IMAGEdefault/override pattern inbase-dev-x.dockerfileandbase-x.dockerfile.build.shoverrides thedefault via
--build-argfor each target; the default exists so standalonedocker buildworks without--build-arg. Comments make this relationshipexplicit.
Extracted from PR #242. That PR removed the defaults entirely, which would
break standalone builds; this PR keeps defaults and adds documentation
instead. Functional package additions (clang-format, torch, black) deferred
as optional follow-up.
Files changed:
docker/base-dev-x.dockerfile— 3-line comment added (lines 1–3)docker/base-x.dockerfile— 2-line comment added (lines 1–2)No functional changes. No Docker CI exists; hadolint clean.